Library table: allow to ignore Track double-click #3194
Conversation
|
@Holzhaus: unfortunately the pre-commit hock on GitHub fails. Can we revive the Travis one I also cannot get used to the cluttered output of the GitHub version. The original text only output is much more informative at once. |
The failure was caused by an in-progress apt mirror sync while installing clang-format. That would have happened on Travis as well. I restarted the jobs and now it works: https://github.com/mixxxdj/mixxx/pull/3194/checks?check_run_id=1281679169#step:5:68
Hmm, I like it actually. The Travis Website became quite slow when showing the huge log. For a text only output, just click the hamburger menu in the top right corner and select "View Raw log" |
There was a problem hiding this comment.
Unfortunatly MSVC fails with
.\src\widget\wtracktableview.cpp(343): error C2589: 'constant': illegal token on right side of '::'
..\src\widget\wtracktableview.cpp(343): error C2062: type 'unknown-type' unexpected
..\src\widget\wtracktableview.cpp(343): error C2143: syntax error: missing ';' before '{'
ronso0
force-pushed
the
doubleclick-library
branch
from
cb701c5 to
4289b95
Compare
|
set to Draft because I overlooked that this change is also suppressing [Library],GoToItem in the tracks table. |
Appearantly m_pLibraryWidget->hasFocus() always returns false. Instead check m_pLibraryWidget->getActiveView()->hasFocus()
ronso0
force-pushed
the
doubleclick-library
branch
from
4289b95 to
ac86cf8
Compare
ronso0
force-pushed
the
doubleclick-library
branch
from
9f8dd09 to
e865387
Compare
Many times a accidental touchpad double-click has caused a PITA in live sessions because it cleared an already prepared deck.
Setting track double-click to "AutoDJ add ..." would protect the decks but pollute the AutoDJ queue.
So I'm adding the valid 'Ignore' option here. Default is untouched (load to deck).
Also the options section is renamed:
Track Load Action>>Track Double Click Action(as the labels extracomment="" already says)